Remove redundant call of usage message #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nappex
commented
Nov 9, 2024
Glutexo
reviewed
Nov 30, 2024
nappex
force-pushed
the
remove-redundant-usage_msg
branch
from
9cd69e5 to
d460b29
Compare
Glutexo
reviewed
Nov 30, 2024
lib/cli.ex
Outdated
| working_dir = Keyword.get(switches, :working_dir, File.cwd!()) | ||
| module.main(working_dir) | ||
| else | ||
| :error -> usage_message() |
There was a problem hiding this comment.
I would question the order: OptionParser.parse is first in the with clause, followed by Map.fetch. Yet the order In else matches the Map.fetch failure first and then the OptionParser.parse ones.
There was a problem hiding this comment.
@Glutexo I had same idea today :D :D, yes it just a detail but could be nice
nappex
commented
Dec 1, 2024
lib/cli.ex
Outdated
| :error -> usage_message() | ||
| {_, _, [_ | _]} -> usage_message() | ||
| {_, argv, _} when length(argv) != 1 -> usage_message() | ||
| _ -> usage_message() |
There was a problem hiding this comment.
If we handle all cases then the not defined may not be catch
Glutexo
requested changes
Dec 17, 2024
lib/cli.ex
Outdated
| {_, _, [_ | _]} -> usage_message() | ||
| {_, argv, _} when length(argv) != 1 -> usage_message() | ||
| :error -> usage_message() | ||
| _ -> usage_message() |
There was a problem hiding this comment.
Now, all cases are covered by the explicit patterns
{_, _, [_ | _]}(invalid switches),{_, argv, _} (invalid argument number),- and
:error(invalid component).
Universal _ would silently swallow any unexpected value. In that case we rather want an error to be raised.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY if it is not necessary, then dont call function more than once.