fix(admin-ui): code smells in test cases auth-server

GluuFederation · Aug 4, 2023 · 582905b · 582905b
1 parent eae73ba
commit 582905b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/admin-ui/plugins/auth-server/_tests_/api/Agama.test.js b/admin-ui/plugins/auth-server/_tests_/api/Agama.test.js
@@ -3,8 +3,8 @@ import { expectSaga } from 'redux-saga-test-plan'
 import authReducer from 'Redux/features/authSlice'
 import {
   getAgamas,
-  addAgama,
-  deleteAgamas,
+  // addAgama,
+  // deleteAgamas,
 } from 'Plugins/auth-server/redux/sagas/AgamaSaga'
 import {
   initialState as agamaInitState,

diff --git a/admin-ui/plugins/auth-server/_tests_/api/AuthN.test.js b/admin-ui/plugins/auth-server/_tests_/api/AuthN.test.js
@@ -33,15 +33,14 @@ const rootReducer = combineReducers({
 })
 
 describe('api tests for authn module', () => {
-  let defaultAuthNMethod
   it('should get custom script by type person_authentication', async () => {
     const result = await expectSaga(getScriptsByType, {
       payload: { action: { type: 'person_authentication' } },
     })
       .withReducer(rootReducer, initialState)
       .silentRun(false)
 
-    defaultAuthNMethod = result.returnValue?.entries?.find(
+    result.returnValue?.entries?.find(
       (item) => item.name === 'simple_password_auth'
     )
     expect(result.returnValue instanceof Error).toBe(false)

diff --git a/admin-ui/plugins/auth-server/_tests_/api/Ssa.test.js b/admin-ui/plugins/auth-server/_tests_/api/Ssa.test.js
@@ -73,7 +73,7 @@ describe('test create, read & delete actions for ssa module', () => {
 
   it('should delete newly created config', async () => {
     if (newConfig) {
-      const result = await expectSaga(removeSsaConfig, {
+      await expectSaga(removeSsaConfig, {
         payload: { action: { action_data: newConfig.ssa.jti } },
       })
         .withReducer(rootReducer, initialState)

diff --git a/admin-ui/plugins/auth-server/components/AuthN/AuthNEditPage.js b/admin-ui/plugins/auth-server/components/AuthN/AuthNEditPage.js
@@ -35,7 +35,7 @@ function AuthNEditPage() {
     const payload = {}
 
     if (item.name === "simple_password_auth") {
-      if (data.defaultAuthNMethod == "true" || data.defaultAuthNMethod == true) {
+      if (data.defaultAuthNMethod === "true" || data.defaultAuthNMethod === true) {
         payload.authenticationMethod = { defaultAcr: "simple_password_auth" }
         dispatch(editSimpleAuthAcr({ data: payload }))
       }
@@ -52,7 +52,7 @@ function AuthNEditPage() {
       ldapPayload.useSSL = data.useSSL
       ldapPayload.enabled = data.enabled
 
-      if (data.defaultAuthNMethod == "true" || data.defaultAuthNMethod == true) {
+      if (data.defaultAuthNMethod === "true" || data.defaultAuthNMethod === true) {
         payload.authenticationMethod = { defaultAcr: data.configId }
         dispatch(editSimpleAuthAcr({ data: payload }))
       }
@@ -75,7 +75,7 @@ function AuthNEditPage() {
             hide: false,
           }))
       }
-      if (data.defaultAuthNMethod == "true" || data.defaultAuthNMethod == true) {
+      if (data.defaultAuthNMethod === "true" || data.defaultAuthNMethod === true) {
         payload.authenticationMethod = { defaultAcr: item.acrName }
         dispatch(editSimpleAuthAcr({ data: payload }))
       }