fix(admin-ui): pr code smells

Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
GluuFederation · Nov 15, 2023 · b0b8d1d · b0b8d1d
1 parent 008fc9c
commit b0b8d1d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/admin-ui/plugins/admin/components/Permissions/PermissionAddDialogForm.js b/admin-ui/plugins/admin/components/Permissions/PermissionAddDialogForm.js
@@ -38,7 +38,7 @@ const PermissionAddDialogForm = ({ handler, modal, onAccept }) => {
       ...(defaultPermissionInToken !== undefined &&
         defaultPermissionInToken !== '' && {
           defaultPermissionInToken:
-            defaultPermissionInToken === 'true' ? true : false,
+            defaultPermissionInToken === 'true',
         }),
     }
 

diff --git a/admin-ui/plugins/admin/components/Permissions/UiPermDetailPage.js b/admin-ui/plugins/admin/components/Permissions/UiPermDetailPage.js
@@ -2,6 +2,7 @@ import React from 'react'
 import { Container, Row, Col } from 'Components'
 import GluuFormDetailRow from 'Routes/Apps/Gluu/GluuFormDetailRow'
 import { PERMISSIONS } from 'Utils/ApiResources'
+import PropTypes from 'prop-types'
 
 function UiPermDetailPage({ row }) {
   const { rowData } = row
@@ -66,4 +67,15 @@ function UiPermDetailPage({ row }) {
   )
 }
 
+UiPermDetailPage.propTypes = {
+  row: PropTypes.shape({
+    rowData: PropTypes.shape({
+      description: PropTypes.string.isRequired,
+      permission: PropTypes.string.isRequired,
+      tag: PropTypes.string.isRequired,
+      defaultPermissionInToken: PropTypes.bool.isRequired,
+    })
+  })
+}
+
 export default UiPermDetailPage