Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): shift SESSION_TIMEOUT_IN_MINUTES to admin-ui configuration in persistence #1575

Closed
duttarnab opened this issue Feb 20, 2024 · 4 comments · Fixed by #1579 or #1580
Closed
Assignees
Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request

Comments

@duttarnab
Copy link
Contributor

Currently, Admin UI session time-out is present in .env file. So it is not possible for user to change timeout in Admin UI.

The solution is to place this field in Admin UI configuration so the user can change it (whenever required).

https://github.com/GluuFederation/flex/blob/main/admin-ui/.env.tmp#L5

image

@duttarnab duttarnab added enhancement New feature or request comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Feb 20, 2024
@duttarnab duttarnab self-assigned this Feb 20, 2024
@duttarnab duttarnab changed the title feat(admin-ui): shit SESSION_TIMEOUT_IN_MINUTES to admin-ui configuration in persistence feat(admin-ui): shift SESSION_TIMEOUT_IN_MINUTES to admin-ui configuration in persistence Feb 20, 2024
jv18creator added a commit that referenced this issue Feb 20, 2024
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
duttarnab added a commit that referenced this issue Feb 21, 2024
feat(admin-ui): fetch sessionTimeout from config response #1575
@duttarnab duttarnab reopened this Feb 22, 2024
@duttarnab
Copy link
Contributor Author

Add screens to set acr values and session-timeout from UI.

@ossdhaval
Copy link
Contributor

@duttarnab It looks like this change may require a documentation update as well. Please evaluate the documentation aspect and make the change along with the code change within this PR itself.

@duttarnab
Copy link
Contributor Author

@ossdhaval Thanks for raising this point. I just raised another issue for docs as I was working on it parallelly. Kindly review it whenever possible.

PR : #1583

@ossdhaval
Copy link
Contributor

@ossdhaval Thanks for raising this point. I just raised another issue for docs as I was working on it parallelly. Kindly review it whenever possible.

PR : #1583

approved ✔️

duttarnab added a commit that referenced this issue Feb 23, 2024
feat(admin-ui): screen to update session timeout #1575
jv18creator added a commit that referenced this issue Feb 23, 2024
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
jv18creator added a commit that referenced this issue Feb 23, 2024
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request
Projects
None yet
2 participants