Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Mark mandatory fields in UI #807

Closed
mzico opened this issue Mar 5, 2023 · 2 comments
Closed

feat(admin-ui): Mark mandatory fields in UI #807

mzico opened this issue Mar 5, 2023 · 2 comments
Assignees
Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request

Comments

@mzico
Copy link
Contributor

mzico commented Mar 5, 2023

Went to create a client and faced issue. I didn't have any indication what I am doing wrong.
Here is the recorded screen: https://www.youtube.com/watch?v=HtU0CEocGV8&ab_channel=MohibZico

Turned out: "Redirect URI" is a mandatory field and after inserting a fake redirect uri, it worked.

We need to mark all mandatory fields so user can understand properly.

@mzico mzico added the enhancement New feature or request label Mar 5, 2023
@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Mar 5, 2023
@duttarnab
Copy link
Contributor

As per current logic, the redirect_uris is mandatory for only authorization_code or implicit grant_types. If you leave the grant_types field blank then it will take the default value i.e. authorization_code. So redirect_uri is required if the grant_types field is blank but not mandatory if grant_type is other than authorization_code or implicit.

We will not mark the redirect_uris field with red Astrics but put an alert if the field is left blank with grant_types authorization_code and implicit.

@duttarnab
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request
Projects
None yet
Development

No branches or pull requests

4 participants