Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add vault support to flex and flex-aio #1589

Merged
merged 9 commits into from
Feb 29, 2024
Merged

fix: add vault support to flex and flex-aio #1589

merged 9 commits into from
Feb 29, 2024

Conversation

misba7
Copy link
Contributor

@misba7 misba7 commented Feb 27, 2024 •
edited by iromli
Loading

closes #1590

@misba7
fix: add vault support to flex and flex-aio
807f87e 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm comp-casa Component affected by issue or PR comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Feb 27, 2024
misba7 and others added 4 commits February 27, 2024 15:05
@misba7
fix: remove global from aio
5619c25 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7
docs: update values.yaml
df2600f 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@iromli
chore(charts): remove unused attributes for Vault integration
be1533d 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli
fix(docker-admin-ui): introduce new env vars for Vault integration
be110d1 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed for 'flex_admin_ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

misba7 and others added 4 commits February 28, 2024 19:18
@misba7
fix: correct indentation
d43a7c1 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7
fix(: add correct vault secret name
62bae90 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7
fix(gluu-all-in-one): correct label
2d0b15d 
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@iromli
feat(charts): allow passing initial keys expiration time
7f18978 
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@moabu moabu merged commit d74790f into main Feb 29, 2024
3 checks passed
@moabu moabu deleted the fix-flex-vault branch February 29, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@iromli iromli Awaiting requested review from iromli iromli is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-admin-ui Component affected by issue or PR comp-casa Component affected by issue or PR comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: add Hashicorps Vault external secret manager
4 participants
@misba7 @moabu @mo-auto @iromli