Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin-ui): add samlMetadata in TR #1584 #1611

Merged
merged 4 commits into from
Mar 12, 2024
Merged

feat(admin-ui): add samlMetadata in TR #1584 #1611

merged 4 commits into from
Mar 12, 2024

Conversation

jv18creator
Copy link
Contributor

closes #1584

@jv18creator
feat(admin-ui): add samlMetadata in TR #1584
a015a02 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Mar 7, 2024
@jv18creator
fix(admin-ui): removed unused vars/imports
1cb7258 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
duttarnab
duttarnab requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove sonar duplicate code.

@jv18creator
fix(admin-ui): render manual fields on TR form #1584
a0bc8d3 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@jv18creator
fix(admin-ui): rename get TR method
f8d81a1 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed for 'flex_admin_ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@duttarnab duttarnab merged commit 3e1c02a into main Mar 12, 2024
3 checks passed
@duttarnab duttarnab deleted the admin-ui-test-1584 branch March 12, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duttarnab duttarnab duttarnab approved these changes

@syntrydy syntrydy Awaiting requested review from syntrydy syntrydy is a code owner

Assignees

@duttarnab duttarnab

Labels
comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(admin-ui): saml TR changes
3 participants
@jv18creator @duttarnab @mo-auto