Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloud-native): reuse pre-built admin-ui app #1732

Merged
merged 6 commits into from
May 31, 2024
Merged

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 28, 2024

The changesets allow container to re-use pre-built admin-ui app.

Ref: #1725

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli changed the title chore: reuse pre-built admin-ui app chore(cloud-native): reuse pre-built admin-ui app May 28, 2024
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-admin-ui Component affected by issue or PR comp-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels May 28, 2024
Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from duttarnab May 29, 2024 18:45
@iromli iromli marked this pull request as ready for review May 29, 2024 18:45
@iromli iromli requested a review from moabu as a code owner May 29, 2024 18:45
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'flex_admin_ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@moabu moabu merged commit c6cb3af into main May 31, 2024
3 of 4 checks passed
@moabu moabu deleted the cn-prebuilt-aui branch May 31, 2024 09:13
jv18creator pushed a commit that referenced this pull request Jun 18, 2024
* chore: reuse pre-built admin-ui app

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* fix(cloud-native): resolve admin URLs

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* chore: remove unused configuration

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* docs: update admin-ui reference in k8s

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* chore: remove unused render_env method

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* chore: remove unused BASE_PATH config

Signed-off-by: iromli <isman.firmansyah@gmail.com>

---------

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-admin-ui Component affected by issue or PR comp-docker-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants