-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cloud-native): reuse pre-built admin-ui app #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iromli <isman.firmansyah@gmail.com>
iromli
changed the title
chore: reuse pre-built admin-ui app
chore(cloud-native): reuse pre-built admin-ui app
May 28, 2024
mo-auto
added
area-documentation
Documentation needs to change as part of issue or PR
comp-docker-admin-ui
Component affected by issue or PR
comp-admin-ui
Component affected by issue or PR
kind-dependencies
Pull requests that update a dependency file
labels
May 28, 2024
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Quality Gate passed for 'flex_admin_ui'Issues Measures |
moabu
approved these changes
May 31, 2024
moabu
approved these changes
May 31, 2024
jv18creator
pushed a commit
that referenced
this pull request
Jun 18, 2024
* chore: reuse pre-built admin-ui app Signed-off-by: iromli <isman.firmansyah@gmail.com> * fix(cloud-native): resolve admin URLs Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: remove unused configuration Signed-off-by: iromli <isman.firmansyah@gmail.com> * docs: update admin-ui reference in k8s Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: remove unused render_env method Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: remove unused BASE_PATH config Signed-off-by: iromli <isman.firmansyah@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-documentation
Documentation needs to change as part of issue or PR
comp-admin-ui
Component affected by issue or PR
comp-docker-admin-ui
Component affected by issue or PR
kind-dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changesets allow container to re-use pre-built admin-ui app.
Ref: #1725