Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Add 'Agama Flows' and 'Alias' tabs in authN. #1800

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

mjatin-dev
Copy link
Contributor

@mjatin-dev mjatin-dev commented Aug 26, 2024

Closes 1793

@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Aug 26, 2024
Copy link

sonarcloud bot commented Aug 26, 2024

Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

@@ -15,6 +15,7 @@ export default class JsonConfigApi {
}
// patch json Config
patchJsonConfig = (options) => {
console.log("options",options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove log if not requied.

path: PLUGIN_BASE_APTH + '/agama',
permission: AGAMA_READ,
},
// {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the comments if not required.

Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Failed Quality Gate failed for 'flex_admin_ui'

Failed conditions
33 New Code Smells (required ≤ 8)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@duttarnab duttarnab merged commit bb34b23 into main Aug 29, 2024
2 of 3 checks passed
@duttarnab duttarnab deleted the admin-ui-issue-1793 branch August 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(admin-ui): Add 'Agama Flows' and 'Alias' tabs in authN.
3 participants