Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud-native): add support for legacy and simple JSON data #1873

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 4, 2024

Description

Target issue

closes #1872

Implementation Details

The changeset adds support for legacy and new simple JSON data format using auto-detection of column's value.

How to test:

  1. Flex 5.1.5 and lower:

    • install flex 5.1.5 chart; ensure format jansAppConf.jansSmtpConf value is {"v": []}
    • upgrade to chart in this PR (change jans image to 1.1.6_json and flex image to 5.1.6); ensure format jansAppConf.jansSmtpConf value is still {"v": []} after upgrade
  2. Flex 5.1.6+:

    • install chart in this PR (change jans image to 1.1.6_json and flex image to 5.1.6_json); ensure format jansAppConf.jansSmtpConf value is []
    • do upgrade; ensure format jansAppConf.jansSmtpConf value is still [] after upgrade

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from misba7 November 4, 2024 17:36
@mo-auto mo-auto added comp-docker-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Nov 4, 2024
@iromli iromli self-assigned this Nov 4, 2024
@iromli iromli marked this pull request as ready for review November 5, 2024 20:34
@iromli iromli requested a review from moabu as a code owner November 5, 2024 20:34
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Copy link

sonarcloud bot commented Nov 6, 2024

@iromli iromli merged commit ddfcba2 into main Nov 7, 2024
4 checks passed
@iromli iromli deleted the cn-json-data-fmt branch November 7, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cloud-native): add support for legacy and simple JSON data
3 participants