-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: hashCode/equals is broken for clients/scopes/NativePersistenceCacheEntity #1651
Labels
Comments
yuriyz
added a commit
to GluuFederation/oxCore
that referenced
this issue
Mar 14, 2022
yuriyz
added a commit
to GluuFederation/oxCore
that referenced
this issue
Mar 14, 2022
yuriyz
added a commit
that referenced
this issue
Mar 14, 2022
yuriyz
added a commit
that referenced
this issue
Mar 14, 2022
yuriyz
added a commit
that referenced
this issue
Mar 14, 2022
yuriyz
added a commit
to JanssenProject/jans
that referenced
this issue
Mar 17, 2022
Issue is fixed in jans, oxauth 4.4.0 (master) and 4.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
bug: hashCode/equals is broken for clients/scopes/NativePersistenceCacheEntity
There are a few symptoms of this:
Cutting to the chase, it looks like the issue was introduced with this commit.
With this change, org.gluu.oxauth.model.registration.Client now inherits the hashCode() and equals() methods from org.gluu.persist.model.base.Entry.
This is a problem because org.gluu.oxauth.model.registration.Client overrides the dn property of Entry, such that hashCode() and equals() are now being computed based on Entry's dn, which is null.
This causes "very bad things" to happen with collections of Clients, for example: here where only the first client ever gets added to the resulting Set since all instances of Client have the same hashCode and are equals() to each other.
Support: 10366
The text was updated successfully, but these errors were encountered: