Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JSON schema configuration files #146

Closed
willow9886 opened this issue Nov 18, 2015 · 2 comments
Closed

Clean up JSON schema configuration files #146

willow9886 opened this issue Nov 18, 2015 · 2 comments
Assignees
@qbert2k
Labels
enhancement libs update, re-factroring, etc.
Milestone
CE 2.4.1

Comments

@willow9886
Copy link
Contributor

https://github.com/GluuFederation/oxTrust/blob/master/static/src/main/resources/META-INF/resources/schema/oxauth-config.xml.json

https://github.com/GluuFederation/oxTrust/blob/master/static/src/main/resources/META-INF/resources/schema/oxtrust.properties.json

These are 2 JSON schema files which we uses in oxTrust to display configuration.

We need to add title, description, min, max, validations… More information about JSON schemas you can find here: http://json-schema.org
@willow9886 willow9886 added the enhancement libs update, re-factroring, etc. label Nov 18, 2015
@willow9886 willow9886 added this to the Version 2.4.1 milestone Nov 18, 2015
@willow9886
Copy link
Contributor Author

@yurem this was originally assigned to @qbert2k in trello, but I'm not sure how progress is going.. perhaps you can provide an update @qbert2k ? Or do we need to re-assign?

@qbert2k qbert2k self-assigned this Nov 25, 2015
qbert2k added a commit that referenced this issue Nov 27, 2015
@qbert2k
Clean up JSON schema configuration files #146
2b95cb1 
Description updated for oxAuth config schema.
qbert2k added a commit that referenced this issue Nov 27, 2015
@qbert2k
Merge pull request #152 from GluuFederation/cleanup-JSON-schema-confi…
192053a 
…g-files

Clean up JSON schema configuration files #146
@qbert2k
Copy link
Contributor

qbert2k commented Nov 27, 2015

Hello William the task is complete and merged into the master branch.
Also I have added description for all the properties in the oxAuth config schema.

@qbert2k qbert2k closed this as completed Nov 27, 2015
qbert2k added a commit that referenced this issue Dec 7, 2015
@qbert2k @yurem
Clean up JSON schema configuration files #146
ef924a1 
Description updated for oxAuth config schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qbert2k qbert2k

Labels
enhancement libs update, re-factroring, etc.
Projects
None yet
Milestone
CE 2.4.1
Development

No branches or pull requests
2 participants
@qbert2k @willow9886