Unable to create Trusted Relationship with uploading metadata file

[uboznikov]

Unable to create Trusted Relationship with uploading metadata file

[sahilIT2020]

Do we have any updates?

[uboznikov]

@shekhar16 What is the purpose of the if(!update){ statement in the case FILE:?

oxTrust issue #384

https://github.com/GluuFederation/oxTrust/blob/master/server/src/main/java/org/gluu/oxtrust/action/UpdateTrustRelationshipAction.java#L285-L287

Above is the cause of this issue. Please review. I am disabling the if for now.

[uboznikov]

[shekhar16]

@uboznikov the purpose of if(!update) is to make status active for only new registering user not for every updating details,if you comment this line it will re-enable the status=Active so. please revert this commit.

[shekhar16]

@uboznikov And how this line will make impact on uploading metadata file ,it is just setting a property status = active or inactive. .

[uboznikov]

@shekhar16 This issue was hard to trace, I compared it with the version before your commit. Please do so, or check my test screenshot above.

[shekhar16]

@uboznikov if you are registering a new trust relationship than why this update value is true.For new TR update should be false.

[shekhar16]

Fixed.

[uboznikov]

@shekhar16 That fix breaks the current code. Please compare to Shib v2 version. I have none or very minimal commits to the UI.

[uboznikov]

@shekhar16 Have you tested it and compared before and after?

[shekhar16]

@uboznikov please check the code which i corrected, the update flag should only been set when it is going to update existing TR ,to check whether it already exist or not ,we are checking initially inum is set or not .
if inum is not set it means new TR has to be register.

i just reverted you code change and commented an update=true line which i think is not needed in this condition, update flag should be set on the basis of inum != null,as the existing TR should have inum .

if it breaks any functionality please let me know so that we can cover it.

[sahilIT2020]

Able to create TR with attaching metadata file. Thanks