New Option: Prevent window snapping with Super key. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteinba
changed the title
asteinba
force-pushed
the
feature/prevent-snapping-with-super
branch
from
29f1e45
to
f4413b4
Compare
meronz
reviewed
Nov 27, 2023
|
Hey @meronz, I'm using this since the last 6 months and didn't notice any issues. Can we merge this? |
|
Sorry for the delay. I merged the PR and I'll do some testing and push the release to EGO today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just started using gSnap, wonderful extension! This PR adds a new option that allows to prevent window snapping by holding down the Super key.
Motivation:
I really like the automatic snapping (so without the need to press CTRL) but from time to time I want to loosely position a window. I added this option so that you can hold Super to disable the window snapping (so basically the opposite from the CTRL option).
Also I'm using the Super key to move (with left click) and resize (with right click) windows but this doesn't work with automatic snapping.
I also think the Super key is the perfect candidate for this as you already use Alt and CTRL for other options.
I hope this feature is fine. Let me know if I need to do any further adjustments :).
Edit: Ah and I just noticed the isHolding function was not working for the SUPER modifier, so I fixed that as well :).