Dark theme compatibility for dialogs. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrown
requested changes
Dec 28, 2024
There was a problem hiding this comment.
overall LGTM but the following unit tests fail
at org.gnucash.android.test.unit.export.GncXmlHelperTest.testParseSplitAmount(GncXmlHelperTest.java:52)
at org.gnucash.android.test.unit.export.GncXmlHelperTest.testFormatSplitAmount(GncXmlHelperTest.java:70)
with the same error
java.lang.RuntimeException: Method isEmpty in android.text.TextUtils not mocked. See https://developer.android.com/r/studio-ui/build/not-mocked for details.
at android.text.TextUtils.isEmpty(TextUtils.java)
at org.gnucash.android.ui.transaction.TransactionFormFragment.stripCurrencyFormatting(TransactionFormFragment.java:1041)
There are multiple results on the web for this exact problem. Not sure which is the most suitable one here..
axiopisty
approved these changes
Dec 29, 2024
djbrown
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.