Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension of Issue #695 - Dependency Injection #39

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Extension of Issue #695 - Dependency Injection #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac75719
Use bound views instead of finding them each usage.
pnemonic78 Jan 7, 2024
8895a41
Grammar
pnemonic78 Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ The two instances of GnuCash Android will live side-by-side on your device and n
* Make small pull requests that are easy to review but which also add value.

## Coding style
* Do write comments. You don't have to comment every line, but if you come up with something thats a bit complex/weird, just leave a comment. Bear in mind that you will probably leave the project at some point and that other people will read your code. Undocumented huge amounts of code are nearly worthless!
* Do write comments. You don't have to comment every line, but if you come up with something that's a bit complex/weird, just leave a comment. Bear in mind that you will probably leave the project at some point and that other people will read your code. Undocumented huge amounts of code are nearly worthless!
* Please make sure to document every method you write using Javadoc, even if the method seems trivial to you
* See [this guide](http://www.oracle.com/technetwork/articles/java/index-137868.html) on how to write good Javadoc comments
* Don't overengineer. Don't try to solve any possible problem in one step, but try to solve problems as easy as possible and improve the solution over time!
* Don't over-engineer. Don't try to solve any possible problem in one step, but try to solve problems as easy as possible and improve the solution over time!
* Do generalize sooner or later! (if an old solution, quickly hacked together, poses more problems than it solves today, refactor it!)
* Keep it compatible. Do not introduce changes to the public API, or configurations too lightly. Don't make incompatible changes without good reasons!

## Translation
* Tranlations for GnuCash Android are managed using [CrowdIn](crowdin.com/project/gnucash-android)
* Translations for GnuCash Android are managed using [CrowdIn](crowdin.com/project/gnucash-android)
* You can sign up for an account and create/vote for translations.
* Translations will not be accepted via pull requests

Expand Down
13 changes: 8 additions & 5 deletions app/src/main/java/org/gnucash/android/ui/transaction/TransactionDetailActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ public class TransactionDetailActivity extends PasscodeLockActivity {
TextView mDebitBalance;
@BindView(R.id.balance_credit)
TextView mCreditBalance;
@BindView(R.id.row_trn_recurrence)
View mRowRecurrence;
@BindView(R.id.row_trn_notes)
View mRowNotes;

@BindView(R.id.fragment_transaction_details)
TableLayout mDetailTableLayout;
Expand Down Expand Up @@ -163,17 +167,16 @@ private void bindViews() {
if (transaction.getScheduledActionUID() != null) {
ScheduledAction scheduledAction = ScheduledActionDbAdapter.getInstance().getRecord(transaction.getScheduledActionUID());
mRecurrence.setText(scheduledAction.getRepeatString());
findViewById(R.id.row_trn_recurrence).setVisibility(View.VISIBLE);

mRowRecurrence.setVisibility(View.VISIBLE);
} else {
findViewById(R.id.row_trn_recurrence).setVisibility(View.GONE);
mRowRecurrence.setVisibility(View.GONE);
}

if (transaction.getNote() != null && !transaction.getNote().isEmpty()) {
mNotes.setText(transaction.getNote());
findViewById(R.id.row_trn_notes).setVisibility(View.VISIBLE);
mRowNotes.setVisibility(View.VISIBLE);
} else {
findViewById(R.id.row_trn_notes).setVisibility(View.GONE);
mRowNotes.setVisibility(View.GONE);
}

}
Expand Down