Skip to content

Commit

Permalink
mm-use-the-light-version-__mod_zone_page_state-in-mlocked_vma_newpage…
Browse files Browse the repository at this point in the history
…-checkpatch-fixes

WARNING: line over 80 characters
torvalds#39: FILE: mm/internal.h:207:
+		 * pte lock is held(spinlock), which implies preemption disabled.

WARNING: line over 80 characters
torvalds#55: FILE: mm/rmap.c:988:
+		 * pte lock(a spinlock) is held, which implies preemption disabled.

total: 0 errors, 2 warnings, 44 lines checked

./patches/mm-use-the-light-version-__mod_zone_page_state-in-mlocked_vma_newpage.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Jianyu Zhan <nasa4836@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed May 14, 2014
1 parent e891e85 commit 894878f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions mm/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,9 @@ static inline int mlocked_vma_newpage(struct vm_area_struct *vma,

if (!TestSetPageMlocked(page)) {
/*
* We use the irq-unsafe __mod_zone_page_stat because
* this counter is not modified from interrupt context, and the
* pte lock is held(spinlock), which implies preemption disabled.
* We use the irq-unsafe __mod_zone_page_stat because this
* counter is not modified from interrupt context, and the pte
* lock is held(spinlock), which implies preemption disabled.
*/
__mod_zone_page_state(page_zone(page), NR_MLOCK,
hpage_nr_pages(page));
Expand Down
3 changes: 2 additions & 1 deletion mm/rmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,8 @@ void do_page_add_anon_rmap(struct page *page,
/*
* We use the irq-unsafe __{inc|mod}_zone_page_stat because
* these counters are not modified from interrupt context, and
* pte lock(a spinlock) is held, which implies preemption disabled.
* pte lock(a spinlock) is held, which implies preemption
* disabled.
*/
if (PageTransHuge(page))
__inc_zone_page_state(page,
Expand Down

0 comments on commit 894878f

Please sign in to comment.