Extract min_diff from GoBoundless/www #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let(:regular_diff) { Dyph::Differ.two_way_diff(left, right) } | ||
| let(:subject) { Dyph.min_diff(left, right) } | ||
|
|
||
| its(:length) { is_expected.to be < regular_diff.length } |
There was a problem hiding this comment.
Hmm, what if instead of just checking that the length is smaller, we check to ensure it matches Dyph::Differ.two_way_diff(right, left)? Optionally also checking that Dyph::Differ.two_way_diff(right, left) < Dyph::Differ.two_way_diff(right, left) so if the test fails, we know it's because of min_diff and not that two_way_diff perhaps got better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously a monkey-patch in our main app. I've extracted it here, but I think having it all in one file may be a little unclean.
invert_actionsandsort_actions(with the supportingChangeGroup) could live elsewhere, but I'm not sure where the existing structure would accept stuff like this.