Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError('unpack requires a buffer of 2 bytes') in SlowPathParser #287

Closed
xshill opened this issue Jan 26, 2021 · 0 comments · Fixed by #291
Closed

ValueError('unpack requires a buffer of 2 bytes') in SlowPathParser #287

xshill opened this issue Jan 26, 2021 · 0 comments · Fixed by #291
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xshill
Copy link
Collaborator

xshill commented Jan 26, 2021

The error is launched at line 621:

https://github.com/GoSecure/pyrdp/blob/master/pyrdp/parser/rdp/slowpath.py#L621

According to the documentation, the pointerCacheSize can be omitted from the structure:

https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/925e2c05-c13f-44b1-aa20-23082051fef9

pointerCacheSize (2 bytes): A 16-bit, unsigned integer. The number of available slots in the pointer cache used to store pointer data of arbitrary bit depth received in the New Pointer Update (section 2.2.9.1.1.4.5).

If the value contained in this field is zero or the Pointer Capability Set sent from the client does not include this field, the server will not use the New Pointer Update.

@xshill xshill added the bug Something isn't working label Jan 26, 2021
@xshill xshill added this to the v1.1.0 milestone Jan 26, 2021
@xshill xshill self-assigned this Jan 26, 2021
@xshill xshill linked a pull request Jan 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant