Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyrdp-player improvements #119

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Pyrdp-player improvements #119

merged 5 commits into from
Jul 29, 2019

Conversation

Pourliver
Copy link
Contributor

After using the live pyrdp-player for a few days, with multiple inbound connections at the same time, I had a few improvement ideas :

  • Give the new tabs a meaningful name (pyrdp codename or hostname)
  • Be clear about which connections are still active, without having to scroll down the log.

The onDisconnection hook wasn't used correctly, so I've removed it, and I added a new rename hook. I rename a tab whenever we receive the clientDataPDU, and on client disconnection. I don't really like using Signals() for that, but it seems common in Qt. Let me know what you think.

@Pourliver Pourliver requested review from xshill and Res260 June 13, 2019 20:33
@Pourliver
Copy link
Contributor Author

After using the player for a few more days, I fixed some things that were getting annoying.

  • We can now see the number of tabs under "Live connections"
  • We can now close the tabs with "Ctrl+W", and there will be a prompt if the connection isn't closed. This is configurable with the new "Options" menu, since a user may prefer to let it passthrough to the connection. The Ctrl+W closes the tab by default.
  • We can now toggle the "Focus new connection" under the options menu. I was observing a connection earlier, and when I got scanned my tab kept changing, which was really annoying. The auto-focus is on by default.

The current options doesn't persist on close.

@Pourliver Pourliver changed the title Added signals to modify pyrdp-player tab name at runtime Pyrdp-player improvements Jun 17, 2019
pyrdp/player/LiveEventHandler.py Show resolved Hide resolved
pyrdp/player/LiveWindow.py Outdated Show resolved Hide resolved
pyrdp/player/LiveWindow.py Outdated Show resolved Hide resolved
pyrdp/player/MainWindow.py Outdated Show resolved Hide resolved
pyrdp/player/LiveTab.py Outdated Show resolved Hide resolved
pyrdp/player/LiveWindow.py Outdated Show resolved Hide resolved
pyrdp/player/LiveTab.py Outdated Show resolved Hide resolved
@Pourliver Pourliver requested a review from xshill June 26, 2019 20:00
@Pourliver Pourliver merged commit e28a31b into master Jul 29, 2019
@obilodeau obilodeau deleted the player_tabname branch November 27, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants