Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better apt-get in Dockerfile #157

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Better apt-get in Dockerfile #157

merged 1 commit into from
Oct 5, 2019

Conversation

ondrg
Copy link
Contributor

@ondrg ondrg commented Oct 5, 2019

Solving issue #156

@Res260
Copy link
Collaborator

Res260 commented Oct 5, 2019

Thanks for your PR! It LGMT but I'll leave the actual review to either @xshill or @obilodeau since I dont know that much about Dockerfiles.

Happy Hacktoberfest :)

@xshill xshill merged commit 0047789 into GoSecure:master Oct 5, 2019
@xshill xshill mentioned this pull request Oct 5, 2019
Closed
@ondrg ondrg deleted the dockerfile-better-apt branch October 6, 2019 10:39
@obilodeau
Copy link
Collaborator

Congratulations on the PR during Hacktoberfest @ondrg! We are giving away stickers in addition to the swag you will get from digital ocean. Details here: https://www.gosecure.net/blog/2019/10/03/hacktoberfest-at-gosecure

May I contact you via email?

@ondrg
Copy link
Contributor Author

ondrg commented Oct 7, 2019

@obilodeau Sure, but this was very small contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xshill xshill xshill approved these changes

@obilodeau obilodeau Awaiting requested review from obilodeau

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ondrg @Res260 @obilodeau @xshill