-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile improvements again #198
Conversation
New Dockerfile worked locally. Triggering an integration build to see how it goes over there and it's resulting size. |
Verified image size in integration. Added at the top of the issue.
Also added a question about tag names alternatives |
Verified image size in integration-gui. Added at the top of the issue.
|
I feel like a lot of images take the |
Changed the Dockerfile to use the slim approach. Configured an integration-slim build rule in DockerHub. |
Image builds that happened during lunch:
|
Merged this into integration to see if it builds. I'll finish and submit the PR tomorrow. |
* Renamed setup.py optional deps from GUI to full * Aligned docker-compose.yml * Documentation updated Some of these changes took for granted that pyrdp-convert is going in. Which I think it will so this is why I introduced full, because we are going to pull ffmpeg-dev and pyav pretty soon.
5e0ed2f
to
d0567d1
Compare
abe6ac9
to
95b2e75
Compare
@obilodeau I don't know if you wanted to do it like that, but you can separate the two docker builds in two different jobs in the CI so they can run in parrallel instead of sequentially |
I decided to keep it into the same task consciously. My rationale was that this is one less ubuntu to start so we save a few seconds of CI time (not sure how much we use though). The two builds are closely related and some of the docker layers might be locally cached. I also believe that if one fails the other will probably too. I haven't thought of the parallel argument. Good call. If I ever find myself waiting too much on this specific CI task I'll think about it. |
Since we merged #190 we can apply further sizing improvements to our docker image
build-essentials
package required)integration-gui
integration-slim
andlatest-gui
latest-slim
tags to dockerhub automatic buildsdocker-compose.yml
and documentationDockerfile.slim
build in CI tooSize reduction
Feedback required for Tag names
Because of @alxbl's upcoming work with video encoding and the needed dependencies, I'm not sure that
-gui
is the proper approach. Candidates:latest
with minimal dependencies andlatest-gui
(with GUI but more later?)latest
with minimal dependencies andlatest-full
(with everything)latest
with everything (GUI + video encoding, etc.) andlatest-slim
(I think python does it that way for official images)