Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale pyrdp-player replays with window height #208

Merged
merged 20 commits into from
Apr 15, 2020
Merged

Scale pyrdp-player replays with window height #208

merged 20 commits into from
Apr 15, 2020

Commits on Apr 9, 2020

  1. maximize pyrdp player on launch

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5e72498 View commit details
    Browse the repository at this point in the history

  2. Support scaling for replays in pyrdp-players (adjusted automatically … 

    …according to window height)
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f84b653 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b0af1ef View commit details
    Browse the repository at this point in the history

  4. Add a checkbox to enable or disable scaling to window size for replay… 

    …s. Defaults to False
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5ceaa41 View commit details
    Browse the repository at this point in the history

  5. merge with master

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    fadbd84 View commit details
    Browse the repository at this point in the history

  6. rename width to sessionWidth to avoid shadowing width() method (same … 

    …for height)
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    80bc8f4 View commit details
    Browse the repository at this point in the history

  7. Refactor resizeEvent handling and remove that logic from mainWindow 

    Bonus: pixel-perfect window scaling instead of arbitrary constant
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    dbf53d3 View commit details
    Browse the repository at this point in the history

  8. Refactor resize method to copy the previous buffer image instead of m… 

    …aking another blank one.

This removes the need to seek upon changing the scale and greatly improves
rescaling performance.
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    bb7b276 View commit details
    Browse the repository at this point in the history

  9. make warning message a bit more visible

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    c6050d9 View commit details
    Browse the repository at this point in the history

  10. change parentResize's signature to send event

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9fdbea2 View commit details
    Browse the repository at this point in the history

  11. update docstring

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    59bbb71 View commit details
    Browse the repository at this point in the history

  12. update QRemoteDesktop docstring

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    287c6bf View commit details
    Browse the repository at this point in the history

  13. Fix bug with signature change

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9ced338 View commit details
    Browse the repository at this point in the history

  14. remove the mainWindowArgument since its now unused

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1937713 View commit details
    Browse the repository at this point in the history

  15. Remove call to resize() in scale() since its not needed anymore

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    fca5833 View commit details
    Browse the repository at this point in the history

  16. clarified docstring in resize() method

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    d39c185 View commit details
    Browse the repository at this point in the history

  17. rename scaleValue to ratio and added docstring to it to remove possib… 

    …le ambiguity
    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3aafbf3 View commit details
    Browse the repository at this point in the history

  18. move comment

    @Res260
    Res260 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    da0f889 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Apply suggestions from code review

    @obilodeau
    obilodeau authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    f00baec View commit details
    Browse the repository at this point in the history

  2. Just copyright things

    @obilodeau
    obilodeau committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    f6edece View commit details
    Browse the repository at this point in the history