NLA redirection #308
Merged
NLA redirection #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
reviewed
Mar 31, 2021
There was a problem hiding this comment.
I have concerns about the interaction of this code with the transparent proxy mode. Are both modes compatible? It should be possible but how will the new server-side TCP connection will be created? It needs to be set with clientIP as its source. Is that covered?
I suppose so, it uses the same functions as previously, just with a different argument. But I haven't tested it tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options
--redirection-hostand--redirection-port. When trying to downgrade from NLA, PyRDP will connect to this host instead of the intended server if it only allows NLA connections.See #260.