Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyRdp-Player optimize for Mac OSX #362

Merged
merged 2 commits into from
Sep 22, 2021
Merged

PyRdp-Player optimize for Mac OSX #362

merged 2 commits into from
Sep 22, 2021

Conversation

thelongestusernameofall
Copy link
Contributor 

Bugfix: 1. fix Memory Not Enough Error (caused by Circular import) by line 37 modification;
2. fix PySide2 freeze Error by line 28 modification;
After these modification, pyrdp-player works well on mac osx.

@thelongestusernameofall
Bugfix: 1. fix Memory Not Enough Error (caused by Circular import) by…
cc274f1 
… line 37 modification;

2. fix PySide2 freeze Error by line 28 modification;
@obilodeau
Copy link
Collaborator

Great contribution! Thanks!

obilodeau
obilodeau reviewed Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment suggestion

bin/pyrdp-player.py Show resolved Hide resolved
@obilodeau obilodeau merged commit dc5cc37 into GoSecure:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obilodeau obilodeau obilodeau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelongestusernameofall @obilodeau