Add support for overriding template dir #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional '-template-dir' flag to 'gotestfmt' cli command that allows overriding of the default template lookup path. Defaults to './.gotestfmt' to maintain backwards compatability. Simplify ciEnvironments mapping to easier support dynamic root template folder. Update 'findTemplate' function to allow passing in a root directory path that is used for os filesystem lookups, but not for embed fs lookups.
|
Hey @obfu5c8 I'm terribly sorry, this PR slipped through the cracks, we'll review this within a few days. |
ghost
approved these changes
May 30, 2023
|
@engelmi I've reviewed this, could you also take a look please? |
|
@janosdebugs LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
I'm using some custom templates for output formatting, and trying to share them between projects.
As it stands, I have to follow an overly complex routine of writing test output json to a file,
cd-ing to my templates folder and then executinggotestfmtusing the-inputflag. It shouldn't be this hard 😭To make (my own) life easier, I've added an optional
-template-dirflag to the cli that allows overriding the base path for template lookups. This way you can point at whatever template folder you want elsewhere on the filesystem.To maintain b/c it defaults to
./.gotestfmt....
Your code will be released under the Unlicense into the public domain for everyone to use for any purpose. Are you in the position, and are you willing to release your code under this license?
👍