Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate if we can insert hooks in the middle of methods #473

Open
Qubus0 opened this issue Nov 26, 2024 · 0 comments
Open

investigate if we can insert hooks in the middle of methods #473

Qubus0 opened this issue Nov 26, 2024 · 0 comments
Labels
4.x enhancement New feature or request investigate
Milestone

Comments

@Qubus0
Copy link
Collaborator

Qubus0 commented Nov 26, 2024

with dynamic hook gen it should be possible for us to insert new hooks at any point of a method.
each insertion will of course change the line numbers so we'll have to keep track of how the vanilla line numbers change, if we are basing the positioning on those (can't think of a more foolproof way)

potential issues

  • indentation needs to be detected
  • this is rather sensitive to changes between game versions
@Qubus0 Qubus0 added enhancement New feature or request investigate 4.x labels Nov 26, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.x milestone Nov 29, 2024
@KANAjetzt KANAjetzt moved this to Backlog in Mod Hooks Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request investigate
Projects
Status: Backlog
Development

No branches or pull requests

2 participants