Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update movement_desktop_turn.gd #687

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

pietru2004
Copy link
Contributor

This might fix #684
or atleast it is an atempt - bit higher in func _process(_delta: float) -> void: there is similar code that hopefully should work as intended...

Note: My VR headset is atm not functional so I can't test it... Graphic drivers issue.

@pietru2004
Copy link
Contributor Author

pietru2004 commented Oct 3, 2024

If I remember correctly

	if clear_cam_x_when_body_not_active:
		player_body.camera_node.rotation_degrees.x=0

was meant for sitting so I think it should be safe to just either comment out it in physics_movement or set it to false by default... or both

Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and appears to work fine.

@Malcolmnixon Malcolmnixon merged commit 9380d06 into GodotVR:master Oct 5, 2024
2 checks passed
@Malcolmnixon Malcolmnixon added this to the 4.4.0 milestone Oct 5, 2024
@Malcolmnixon Malcolmnixon added the bug Something isn't working label Oct 5, 2024
@pietru2004 pietru2004 deleted the patch-1 branch October 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Turn overwriting camera X-Rotation even in full XR mode
2 participants