Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add focus awareness support #98

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Apr 2, 2020

Fixes issue #92

Part 1 of the implementation.
The second part needs to happen in the Godot engine, and involve adding an export option for focus awareness support.

@m4gr3d m4gr3d added the enhancement New feature or request label Apr 2, 2020
@m4gr3d m4gr3d added this to the 2.0.0 milestone Apr 2, 2020
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried running the code but it looks good to me, so we're just adding signals here to when the HMD has become available and when we get focus or not, I guess that last one for when we switch to the home/settings interface and back?

@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Apr 4, 2020

The focus awareness one is tricky to test since according to the documentation, it requires that the app be approved by Oculus for access to the api on the headset.
If the app is approved, then the home menu does appear in the app and the events are dispatched synchronously. Otherwise, the app exits to the home menu as usual, and the events are only dispatched when the user gets back to it.

Nonetheless, having the implementation makes us future-proof in case they decide to expand its access.

@m4gr3d m4gr3d merged commit 8ddbac7 into GodotVR:master Apr 4, 2020
@m4gr3d m4gr3d deleted the add_focus_awareness_support branch April 4, 2020 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants