Switch to get_predicted_display_time() and update extension_api.json and godot-cpp
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
May 7, 2024
…on` and godot-cpp
dsnopek
force-pushed
the
get-predicted-display-time
branch
from
867f799 to
750dc34
Compare
|
Now that PR #121 is merged, I've rebased and updated the code added by that PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
This required updating godot-cpp as well, because the latest
extension_api.jsonhasPackedVector4Arraywhich won't compile without the latest godot-cpp.After PR #121 is merged, I'll add the updates for that one as well. Or, if this PR is merged first, I'll update the other forget_predicted_display_time().