Refactor the Godot OpenXR loader to match the new Android plugin packaging format for Godot 4.2 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
documentation
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
12bb76f
to
c35d378
Compare
BastiaanOlij
reviewed
Jul 3, 2023
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
c35d378
to
f3a42f7
Compare
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
f3a42f7
to
ced51e7
Compare
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
2 times, most recently
from
ddac025
to
d4416b0
Compare
BastiaanOlij
reviewed
Jul 5, 2023
|
I'm guessing Also don't we need .gdignore files in the plugin somewhere to ensure it's not exported? |
BastiaanOlij
reviewed
Jul 5, 2023
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
6 times, most recently
from
08c8d30
to
9b36b7c
Compare
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
9b36b7c
to
1d265cc
Compare
|
Note that I have bumped the version to We may want to keep a |
I think that makes a lot of sense |
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
1d265cc
to
e1860d8
Compare
BastiaanOlij
approved these changes
Jul 18, 2023
YuriSizov
pushed a commit
to m4gr3d/godot
that referenced
this pull request
Jul 18, 2023
Following on the previous commit, the XR features logic have now be moved to the Godot OpenXR loader plugin. See GodotVR/godot_openxr_vendors#38
|
godotengine/godot#78958 has been merged, so this PR should be good to go! |
…aging format for Godot 4.2 The new format gives a lot of flexibility and allows each vendor plugin to provide its own set of parameters in the export window. Those parameters in turn influences how the Android manifest is generated.
m4gr3d
force-pushed
the
godot_4_2_refactor
branch
from
e1860d8
to
ee29b8d
Compare
suinswofi
pushed a commit
to suinswofi/godot
that referenced
this pull request
Jul 20, 2023
Following on the previous commit, the XR features logic have now be moved to the Godot OpenXR loader plugin. See GodotVR/godot_openxr_vendors#38
IntangibleMatter
pushed a commit
to IntangibleMatter/godot
that referenced
this pull request
Aug 13, 2023
Following on the previous commit, the XR features logic have now be moved to the Godot OpenXR loader plugin. See GodotVR/godot_openxr_vendors#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format gives a lot of flexibility and allows each vendor plugin to provide its own set of parameters in the export window. Those parameters in turn influences how the Android manifest is generated.
See godotengine/godot#78958 for reference.