GongGanGam-UI.framework #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByeongjooYoo
approved these changes
Jan 25, 2023
Comment on lines
16
to
33
| public enum Pretendard { | ||
|
|
||
| // MARK: - Bold | ||
| public static let h1 = GongGanGamUIFontFamily.Pretendard.bold.font(size: 22) | ||
| public static let titleBold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 17) | ||
| public static let bodyBold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 16) | ||
| public static let caption1Bold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 14) | ||
| public static let caption2Bold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 12) | ||
| public static let button1 = GongGanGamUIFontFamily.Pretendard.bold.font(size: 16) | ||
|
|
||
| // MARK: - Regular | ||
| public static let title = GongGanGamUIFontFamily.Pretendard.regular.font(size: 17) | ||
| public static let body = GongGanGamUIFontFamily.Pretendard.regular.font(size: 16) | ||
| public static let caption1 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 14) | ||
| public static let caption2 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 12) | ||
| public static let button2 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 14) | ||
| public static let small = GongGanGamUIFontFamily.Pretendard.regular.font(size: 10) | ||
| } |
chansooo
approved these changes
Jan 25, 2023
Comment on lines
16
to
33
| public enum Pretendard { | ||
|
|
||
| // MARK: - Bold | ||
| public static let h1 = GongGanGamUIFontFamily.Pretendard.bold.font(size: 22) | ||
| public static let titleBold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 17) | ||
| public static let bodyBold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 16) | ||
| public static let caption1Bold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 14) | ||
| public static let caption2Bold = GongGanGamUIFontFamily.Pretendard.bold.font(size: 12) | ||
| public static let button1 = GongGanGamUIFontFamily.Pretendard.bold.font(size: 16) | ||
|
|
||
| // MARK: - Regular | ||
| public static let title = GongGanGamUIFontFamily.Pretendard.regular.font(size: 17) | ||
| public static let body = GongGanGamUIFontFamily.Pretendard.regular.font(size: 16) | ||
| public static let caption1 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 14) | ||
| public static let caption2 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 12) | ||
| public static let button2 = GongGanGamUIFontFamily.Pretendard.regular.font(size: 14) | ||
| public static let small = GongGanGamUIFontFamily.Pretendard.regular.font(size: 10) | ||
| } |
There was a problem hiding this comment.
폰트 사용할 때 size를 지정해야 하는 불편함 해소되겠네요!
chansooo
approved these changes
Jan 26, 2023
Comment on lines
+106
to
+115
| dependencies: [ | ||
| .package(product: "FlexLayout"), | ||
| .package(product: "PinLayout"), | ||
| ], | ||
| settings: .settings( | ||
| base: [ | ||
| "GCC_PREPROCESSOR_DEFINITIONS[arch=*]": "FLEXLAYOUT_SWIFT_PACKAGE=1", | ||
| ], | ||
| configurations: [.debug(name: .debug)] | ||
| ) |
There was a problem hiding this comment.
package로 추가하는 것과 external로 추가하는 건 어떤 차이가 있을까요?
There was a problem hiding this comment.
그 spm으로 직접 세팅하면 package product 써야하는 것 같슴닷
There was a problem hiding this comment.
package로 추가하는 거랑 external로 추가하는 것 차이를 모르겟서서 그런데 external로 안되는 게 package로 되면 package 짱짱맨으로 하면 안되나여?
There was a problem hiding this comment.
external로 하면 트위스트에서 자체적으로 spm 패키지 받아서 타겟만 추가해주는것이고 (그래서 Xcode 파일 목록 밑쪽에 Tuist/Dependencies 폴더에 프로젝트로 들어갑니다)
package로 하면 Xcode spm 활용해서 타겟 추가해주는 차이인 것 같슴다 (그래서 Xcode 파일 목록 맨 아래쪽에 spm으로 추가할 때 처럼 Package Dependencies로 들어갑니다)
doc에도 external보다 package로 하면 좋다고 적혀있기는 하는데 정확히 뭐가 더 좋다는지는 잘 모르겠네요 ㅋㅋㅋ
TitledView, TitledTextField
chansooo
approved these changes
Jan 26, 2023
…otion-view SelectionView
feat: create CheckBox
…m-button GongGanGamButton 구현
…mage-view ProfileImageView
…content-cell feat: create ReceivedContentCell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
질문 및 특이사항
체크리스트