Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS16] support live activity #1

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Conversation

GonzaloAvilez
Copy link
Owner

@GonzaloAvilez GonzaloAvilez commented May 9, 2023


Documentation reference to Header aps-push-type -> https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns

Documentation reference for aps payload to support live-activity ->
https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification#2943360

Purpose:

  • add support for live-activity payload
    stale-date
    content-state
    timestamp
    event **

  • add support for live-activity header

**NOTE: To verify if correct field is event or events apple docs could have a typo error

Change Files:

notification.go -> support liveactivity header
payload/builder.go -> implenting stale-date, content-state, timestamp and event to aps payload

TEST results:
image

tests passed
image

image

Copy link

@alefer9 alefer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@IvanTrivino
Copy link

Is it possible to do some E2E tests in an experimental env with these changes?

@GonzaloAvilez
Copy link
Owner Author

Is it possible to do some E2E tests in an experimental env with these changes?

@IvanTrivino iOS team are working in their side to support live activity right now. Once they get a way to receive the notification content in the app, we will test this feature via command line.
This library has a great command line tool, to fire notifications within the code.

image

@GonzaloAvilez GonzaloAvilez self-assigned this May 9, 2023
@GonzaloAvilez GonzaloAvilez force-pushed the feature/support-live-activity branch from b62c541 to 330f296 Compare July 7, 2023 16:35
@GonzaloAvilez GonzaloAvilez marked this pull request as ready for review July 25, 2023 17:06
payload/builder.go Outdated Show resolved Hide resolved
payload/builder.go Outdated Show resolved Hide resolved
Copy link

@JoseRivera12 JoseRivera12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a comment on naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants