Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18 Update #137

Merged
merged 44 commits into from
Nov 14, 2021
Merged

1.18 Update #137

merged 44 commits into from
Nov 14, 2021

Conversation

Goobwabber
Copy link
Owner

@Goobwabber Goobwabber commented Jul 20, 2021

nice

@Goobwabber Goobwabber linked an issue Jul 20, 2021 that may be closed by this pull request
@Goobwabber Goobwabber marked this pull request as draft July 20, 2021 21:22
@tjhorner
Copy link

tjhorner commented Aug 6, 2021

Need any help with this? I'm glad to assist wherever I can

@xplodwild
Copy link

Same here, if there's anything I can do to help make this happen quicker, I'm all in!

@xplodwild
Copy link

@Goobwabber could you just update us if there's any unpushed code that you have locally, and if this is still being worked on? I'd love to contribute some code otherwise

@Goobwabber
Copy link
Owner Author

Goobwabber commented Aug 8, 2021

@xplodwild check message on the issue attached to this pr
Sorry for my lack of transparency in the past weeks.

@monkeeee
Copy link

Hey, i wanna help. U got a TODO list or is just everything broken by the Update?

- Deleted Custom Songs State
- Deleted Free Mod
- Deleted Host Pick
- Deleted Statistics
@Goobwabber
Copy link
Owner Author

Right ok so almost ready for public C:

@Skyethebaka
Copy link

When will it be ready?

@xplodwild
Copy link

When will it be ready?

I tried to build and play the 1.16.3 branch (this PR), while everything seems fine, the "Start game" button remains greyed out with the text "No song selected" (although it displays as the next song at the top etc).
I tried to hack it to force the Start game button to be enabled, but after the countdown, nothing happens, so I guess I'm still missing something somewhere. It seems close to be ready though!

@qe201020335
Copy link

qe201020335 commented Oct 3, 2021

As stated in #146 by Goobie

I ended up deleting all code related to making it work on official servers because it wasn't worth how buggy things would be. BeatTogether's dedicated servers are currently in testing phase and the new commits are made to work with those servers instead. Since the mod hasn't been publicly released I'm closing this issue.

Though, I can confirm that there is one commit, that you can add a tiny fix, works for both 1.17 and 1.18. (I have been using it with my friend for a month now.)

HINT Look into my fork and this pr #145

@Skyethebaka
Copy link

As stated in #146 by Goobie

I ended up deleting all code related to making it work on official servers because it wasn't worth how buggy things would be. BeatTogether's dedicated servers are currently in testing phase and the new commits are made to work with those servers instead. Since the mod hasn't been publicly released I'm closing this issue.

Though, I can confirm that there is one commit, that you can add a tiny fix and works for both 1.17 and 1.18. (I have been using it with my friend for a month now.)

HINT

How have you been playing it when it’s not released?

@qe201020335
Copy link

qe201020335 commented Oct 3, 2021

How have you been playing it when it’s not released?

I built and tested it myself. If it's not working, then fix it enough so that it is usable.

This being said, my build is only for private use since it is still an unfinished mod. Anything could go wrong. The way it tricks the official server to accept a custom level can make a mess when error happens.

@xplodwild
Copy link

Thanks @qe201020335! I used your fork and did "that change" (wink wink) to make it work and had a fun session with a friend.
Makes me realize how much better the game is with custom songs :)

@Skyethebaka
Copy link

is it almost done? sorry very excited

@robinbecx
Copy link

is it almost done? sorry very excited

Same here

Copy link

@BillyBobJones678 BillyBobJones678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still working on it I see

@doug-cannon
Copy link

Is this Multiplayer Extension mod working for Beat Saber 1.18.1? The last time I've played, it was like on version 1.16. So I downloaded this and copied it into my Plugins folder, and it still would not work—just the default multiplayer.

@ghost
Copy link

ghost commented Oct 30, 2021

@Goobwabber any news on this?

Fix MultiplayerModeSelectionFlowCoordinatorPatch, Remove ConnectToMatchmakingPatch, Improve CenterScreenLoadingPanel
@Goobwabber
Copy link
Owner Author

nice

@Goobwabber Goobwabber merged commit e70690a into master Nov 14, 2021
@Goobwabber Goobwabber deleted the 1.16.3 branch November 14, 2021 16:28
@gellis12
Copy link

Been waiting for this day for such a long time, thanks for all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UPDATE] Beatsaber 1.18