Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) GoodWallet Ethereum support - enhancements #4091

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

johnsmith-gooddollar
Copy link
Collaborator

@johnsmith-gooddollar johnsmith-gooddollar commented Sep 18, 2023

Description

  • replaced hardcoded titles like const RECEIVE_TITLE = 'Receive G$' with the new NavBar showing token name
  • found solution for unsafe wallet passing to threaddb

About #4083

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:01pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 2:01pm
goodid ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 2:01pm

@johnsmith-gooddollar
Copy link
Collaborator Author

@sirpy regarding the last one point - please look #4083 (comment)

@johnsmith-gooddollar johnsmith-gooddollar marked this pull request as ready for review September 19, 2023 11:57
@johnsmith-gooddollar
Copy link
Collaborator Author

@sirpy could You please review this week ?

src/components/dashboard/SendQRSummary.js Outdated Show resolved Hide resolved
src/components/dashboard/TransactionConfirmation.js Outdated Show resolved Hide resolved
@johnsmith-gooddollar johnsmith-gooddollar merged commit aa65e73 into master Oct 30, 2023
9 of 16 checks passed
@johnsmith-gooddollar johnsmith-gooddollar deleted the eth-delta-enhancements branch October 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants