Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nodoc for MAX_NUMBER_OF_DYNAMIC_RULES #61

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

oliverdunk
Copy link
Member

@oliverdunk oliverdunk commented Nov 16, 2023

In the chrome.declarativeNetRequest types, we are showing an unhelpful output for MAX_NUMBER_OF_DYNAMIC_RULES:

Screenshot 2023-11-16 at 11 25 20

This has actually been present for many Chrome versions but when we added session rules, we added nodoc thinking we would remove it in a future version.

As part of implementing safe rules, however, we're bringing it back. This confused chrome-types since it essentially went missing for a while.

There are two commits here:

  • The first is the actual fix and just ignores the nodoc.
  • The second is adding some comments and a test for a "this should never be hit" section of code that I got an understanding of as part of investigating this. It isn't really needed, but I had already written it before I realised that so felt worth committing.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85e3dd9) 43.86% compared to head (baa1077) 44.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   43.86%   44.03%   +0.17%     
==========================================
  Files          21       21              
  Lines        4024     4026       +2     
  Branches      264      264              
==========================================
+ Hits         1765     1773       +8     
+ Misses       2259     2253       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverdunk oliverdunk changed the title Fix "since" data for temporarily removed types Ignore nodoc for MAX_NUMBER_OF_DYNAMIC_RULES Nov 16, 2023
@oliverdunk oliverdunk force-pushed the fix-removed-types branch 2 times, most recently from 7767497 to c777354 Compare November 16, 2023 11:57
@oliverdunk oliverdunk merged commit 9ed0d21 into main Nov 16, 2023
@oliverdunk oliverdunk deleted the fix-removed-types branch November 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants