Ignore nodoc for MAX_NUMBER_OF_DYNAMIC_RULES #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the chrome.declarativeNetRequest types, we are showing an unhelpful output for
MAX_NUMBER_OF_DYNAMIC_RULES
:This has actually been present for many Chrome versions but when we added session rules, we added nodoc thinking we would remove it in a future version.
As part of implementing safe rules, however, we're bringing it back. This confused chrome-types since it essentially went missing for a while.
There are two commits here: