modify test to allow default array for stackPacks

GoogleChrome · Apr 25, 2019 · 2a22744 · 2a22744
1 parent 1b450ba
commit 2a22744
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lighthouse-core/test/report/proto-test.js b/lighthouse-core/test/report/proto-test.js
@@ -45,12 +45,19 @@ describe('round trip JSON comparison subsets', () => {
  });
 
  it('has the same top level values', () => {
+ // Don't test all top level properties that are objects.
  Object.keys(sampleJson).forEach(audit => {
  if (typeof sampleJson[audit] === 'object' && !Array.isArray(sampleJson[audit])) {
  delete sampleJson[audit];
  }
  });
 
+ // Properties set to their type's default value will be omitted in the roundTripJson.
+ // For an explicit list of properties, remove sampleJson values if set to a default.
+ if (Array.isArray(sampleJson.stackPacks) && sampleJson.stackPacks.length === 0) {
+ delete sampleJson.stackPacks;
+ }
+
  expect(roundTripJson).toMatchObject(sampleJson);
  });