getRequestContent 1s

GoogleChrome · Oct 24, 2018 · 368f722 · 368f722
1 parent 0e70d6f
commit 368f722
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -881,11 +881,11 @@ class Driver {
    * @param {number} timeout
    * @return {Promise<string>}
    */
-  async getRequestContent(requestId, timeout = 5000) {
+  async getRequestContent(requestId, timeout = 1000) {
     requestId = NetworkRequest.getRequestIdForBackend(requestId);
 
     // Encoding issues may lead to hanging getResponseBody calls: https://github.com/GoogleChrome/lighthouse/pull/4718
-    // driver.sendCommand will handle timeout after 5s.
+    // driver.sendCommand will handle timeout after 1s.
     this.setNextProtocolTimeout(timeout);
     const result = await this.sendCommand('Network.getResponseBody', {requestId});
     return result.body;

diff --git a/proto/lighthouse-result.proto b/proto/lighthouse-result.proto
@@ -44,7 +44,7 @@ enum LighthouseError {
   READ_FAILED = 16;
   // Used when security error prevents page load.
   INSECURE_DOCUMENT_REQUEST = 17;
-  // Used when security error prevents page load.
+  // Used when protocol command times out.
   PROTOCOL_TIMEOUT = 18;
 }