3.2.1 (#6149)

GoogleChrome · Oct 1, 2018 · 3c03e2c · 3c03e2c
1 parent 081864e
commit 3c03e2c
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 7 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,12 @@
+ <a name="3.2.1"></a>
+# 3.2.1 (2018-10-01)
+[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.2.0...v3.2.1)
+
+## Core
+
+* await js-libraries detection to fix Workbox always showing up ([#6141](https://github.com/googlechrome/lighthouse/pull/6141))
+* emulation: set desktop viewport to 1350x940 ([#6131](https://github.com/googlechrome/lighthouse/pull/6131))
+
  <a name="3.2.0"></a>
 # 3.2.0 (2018-09-27)
 [Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.1.1...v3.2.0)

diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
@@ -138,6 +138,14 @@ module.exports = [
           ],
         },
       },
+      'js-libraries': {
+        score: 1,
+        details: {
+          items: [{
+            name: 'jQuery',
+          }],
+        },
+      },
     },
   },
 ];
diff --git a/lighthouse-core/gather/gatherers/dobetterweb/js-libraries.js b/lighthouse-core/gather/gatherers/dobetterweb/js-libraries.js
@@ -29,9 +29,9 @@ function detectLibraries() {
   // d41d8cd98f00b204e9800998ecf8427e_ is a consistent prefix used by the detect libraries
   // see https://github.com/HTTPArchive/httparchive/issues/77#issuecomment-291320900
   // @ts-ignore - injected libDetectorSource var
-  Object.entries(d41d8cd98f00b204e9800998ecf8427e_LibraryDetectorTests).forEach(([name, lib]) => {
+  Object.entries(d41d8cd98f00b204e9800998ecf8427e_LibraryDetectorTests).forEach(async ([name, lib]) => { // eslint-disable-line max-len
     try {
-      const result = lib.test(window);
+      const result = await lib.test(window);
       if (result) {
         libraries.push({
           name: name,

diff --git a/lighthouse-core/lib/emulation.js b/lighthouse-core/lib/emulation.js
@@ -33,8 +33,8 @@ const NEXUS5X_EMULATION_METRICS = {
  */
 const DESKTOP_EMULATION_METRICS = {
   mobile: false,
-  width: 1366,
-  height: 768,
+  width: 1350,
+  height: 940,
   deviceScaleFactor: 1,
 };
 

diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
@@ -5,7 +5,7 @@
     "hostUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36",
     "benchmarkIndex": 1000
   },
-  "lighthouseVersion": "3.2.0",
+  "lighthouseVersion": "3.2.1",
   "fetchTime": "2018-03-13T00:55:45.840Z",
   "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
   "finalUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",

diff --git a/lighthouse-extension/app/manifest.json b/lighthouse-extension/app/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "__MSG_appName__",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "minimum_chrome_version": "66",
   "manifest_version": 2,
   "description": "__MSG_appDescription__",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "Lighthouse",
   "main": "./lighthouse-core/index.js",
   "bin": {