Skip to content

Commit

Permalink
tests(viewer): don't override puppeteer's chromium (#9877)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored and paulirish committed Nov 6, 2019
1 parent 872e970 commit 41dd404
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ cache:
install:
# Ensure we have the latest Chrome stable.
- google-chrome-stable --version
# if our e2e tests fail in the future it might be that we are not compatible
# with the latest puppeteer api so we probably need to run on chromimum
# @see https://github.com/GoogleChrome/lighthouse/pull/4640/files#r171425004
- export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
# We used to set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD, but we don't want to anymore.
# Explicitly unset b/c environment variables seem to linger in travis.
# see https://github.com/GoogleChrome/lighthouse/pull/9877#discussion_r338389765
- unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD
- yarn --frozen-lockfile
before_script:
# see comment above about puppeteer
Expand Down
1 change: 0 additions & 1 deletion lighthouse-viewer/test/viewer-test-pptr.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ describe('Lighthouse Viewer', () => {
// start puppeteer
browser = await puppeteer.launch({
headless: true,
executablePath: process.env.CHROME_PATH,
});
viewerPage = await browser.newPage();
viewerPage.on('pageerror', pageError => pageErrors.push(pageError));
Expand Down

0 comments on commit 41dd404

Please sign in to comment.