core(tsc): add tsc type checking to report (#5195)

GoogleChrome · May 17, 2018 · 4a046e0 · 4a046e0
1 parent 632eb32
commit 4a046e0
Show file tree

Hide file tree

Showing 21 changed files with 455 additions and 588 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -35,7 +35,6 @@ script:
   - yarn lint
   - yarn unit:silentcoverage
   - yarn type-check
-  - yarn closure
   - yarn diff:sample-json
   - yarn smoke:silentcoverage
   - yarn test-extension

diff --git a/lighthouse-core/closure/closure-type-checking.js b/lighthouse-core/closure/closure-type-checking.js
diff --git a/lighthouse-core/closure/conformance_config.textproto b/lighthouse-core/closure/conformance_config.textproto
diff --git a/lighthouse-core/lib/dependency-graph/simulator/simulator.js b/lighthouse-core/lib/dependency-graph/simulator/simulator.js
@@ -321,7 +321,7 @@ class Simulator {
 
     options = Object.assign({flexibleOrdering: false}, options);
     // initialize the necessary data containers
-    this._flexibleOrdering = options.flexibleOrdering;
+    this._flexibleOrdering = !!options.flexibleOrdering;
     this._initializeConnectionPool(graph);
     this._initializeAuxiliaryData();