Skip to content

Commit

Permalink
Fix comments and add additional explanation in one of the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kdzwinel committed Oct 28, 2017
1 parent eee0b5a commit 5bb9d4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lighthouse-core/audits/seo/is-crawlable.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function isUnavailable(directive) {
}

/**
* Returns false if any of provided directives blocks page from being indexed
* Returns true if any of provided directives blocks page from being indexed
* @param {string} directives
* @returns {boolean}
*/
Expand All @@ -42,7 +42,7 @@ function hasBlockingDirective(directives) {
}

/**
* Returns false if robots header specifies user agent (e.g. `googlebot: noindex`)
* Returns true if robots header specifies user agent (e.g. `googlebot: noindex`)
* @param {string} directives
* @returns {boolean}
*/
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/test/audits/seo/is-crawlable-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ describe('SEO: Is page crawlable audit', () => {
const mainResource = {
responseHeaders: [
{name: 'x-robots-tag', value: 'googlebot: unavailable_after: 25 Jun 2007 15:00:00 PST'},
{name: 'x-robots-tag', value: 'unavailable_after: 25 Jun 2045 15:00:00 PST'},
],
};
const artifacts = {
Expand Down

0 comments on commit 5bb9d4f

Please sign in to comment.