Skip to content

Commit

Permalink
things
Browse files Browse the repository at this point in the history
  • Loading branch information
brendankenny committed Jan 11, 2019
1 parent 71b45b3 commit 6c82f88
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lighthouse-core/report/html/renderer/category-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class CategoryRenderer {
}

/**
* Take a set of audits and render in a top-level expandable clump that starts
* Take a set of audits and render in a top-level, expandable clump that starts
* in a collapsed state.
* @param {Exclude<TopLevelClumpId, 'failed'>} clumpId
* @param {{auditRefs: Array<LH.ReportResult.AuditRef>, description?: string}} clumpOpts
Expand Down Expand Up @@ -395,18 +395,18 @@ class CategoryRenderer {
}

// Render each clump.
for (const [clumpId, clumpRefs] of clumps) {
if (clumpRefs.length === 0) continue;
for (const [clumpId, auditRefs] of clumps) {
if (auditRefs.length === 0) continue;

if (clumpId === 'failed') {
const clumpElem = this.renderUnexpandableClump(clumpRefs, groupDefinitions);
const clumpElem = this.renderUnexpandableClump(auditRefs, groupDefinitions);
clumpElem.classList.add(`lh-clump--failed`);
element.appendChild(clumpElem);
continue;
}

const description = clumpId === 'manual' ? category.manualDescription : undefined;
const clumpElem = this.renderClump(clumpId, {auditRefs: clumpRefs, description});
const clumpElem = this.renderClump(clumpId, {auditRefs, description});
element.appendChild(clumpElem);
}

Expand Down

0 comments on commit 6c82f88

Please sign in to comment.