core(bf-cache): count failures based on affected frames (#14823)

GoogleChrome · Feb 23, 2023 · 8ab11e9 · 8ab11e9
1 parent 4ef4cfb
commit 8ab11e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/core/audits/bf-cache.js b/core/audits/bf-cache.js
@@ -74,13 +74,17 @@ class BFCache extends Audit {
     // TODO: Analyze more than one bf cache failure.
     const {notRestoredReasonsTree} = failures[0];
 
+    let totalIssues = 0;
+
     /** @type {LH.Audit.Details.TableItem[]} */
     const results = [];
 
     for (const failureType of ORDERED_FAILURE_TYPES) {
       const reasonsMap = notRestoredReasonsTree[failureType];
 
       for (const [reason, frameUrls] of Object.entries(reasonsMap)) {
+        totalIssues += frameUrls.length;
+
         results.push({
           reason: NotRestoredReasonDescription[reason]?.name ?? reason,
           failureType: FAILURE_TYPE_TO_STRING[failureType],
@@ -104,8 +108,8 @@ class BFCache extends Audit {
 
     const details = Audit.makeTableDetails(headings, results);
 
-    const displayValue = results.length ?
-      str_(UIStrings.displayValue, {itemCount: results.length}) :
+    const displayValue = totalIssues ?
+      str_(UIStrings.displayValue, {itemCount: totalIssues}) :
       undefined;
 
     return {

diff --git a/core/test/audits/bf-cache-test.js b/core/test/audits/bf-cache-test.js
@@ -27,7 +27,7 @@ describe('BFCache audit', () => {
 
     const result = await BFCache.audit(artifacts);
 
-    expect(result.displayValue).toBeDisplayString('3 failure reasons');
+    expect(result.displayValue).toBeDisplayString('4 failure reasons');
     expect(result.score).toEqual(0);
 
     if (result.details?.type !== 'table') throw new Error('details were not a table');