tests(smoke): re-enable dialog prompt (#8894)

GoogleChrome · May 28, 2019 · 9d4d7ed · 9d4d7ed
1 parent 52b2023
commit 9d4d7ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -198,8 +198,8 @@ <h2>Do better web tester page</h2>
   https://github.com/GoogleChrome/lighthouse/issues/1194 -->
 <script>window.Error = function(error) { this.stack = 'stacktrace'; };</script>
 
-<!--The javascriptDialogOpening test is disabled as we hit a platform bug frequently on travis-->
-<!--<script>window.confirm('Is DBW Mega Tester the best site?')</script>-->
+<!-- Does the automatic dialog suppression `driver.dismissJavaScriptDialogs()` work? -->
+<script>window.confirm('Is DBW Mega Tester the best site?')</script>
 
 <script>
 function stampTemplate(id, location) {

diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
@@ -155,12 +155,12 @@ module.exports = [
         },
         'dom-size': {
           score: 1,
-          numericValue: 34,
+          numericValue: 35,
           details: {
             items: [
-              {statistic: 'Total DOM Elements', value: '34'},
+              {statistic: 'Total DOM Elements', value: '35'},
               {statistic: 'Maximum DOM Depth', value: '3'},
-              {statistic: 'Maximum Child Elements', value: '32'},
+              {statistic: 'Maximum Child Elements', value: '33'},
             ],
           },
         },