Fix url rendering in report

GoogleChrome · Apr 10, 2018 · ab9137c · ab9137c
1 parent e9f98d4
commit ab9137c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/lighthouse-core/report/v2/renderer/details-renderer.js b/lighthouse-core/report/v2/renderer/details-renderer.js
@@ -96,8 +96,8 @@ class DetailsRenderer {
     let title;
     try {
       const parsed = Util.parseURL(url);
-      displayedPath = parsed.file;
-      displayedHost = parsed.hostname ? `(${parsed.hostname})` : '';
+      displayedPath = parsed.file === '/' ? parsed.origin :parsed.file;
+      displayedHost = parsed.file === '/' ? '' : `(${parsed.hostname})`;
       title = url;
     } catch (/** @type {!Error} */ e) {
       if (!(e instanceof TypeError)) {

diff --git a/lighthouse-core/report/v2/renderer/util.js b/lighthouse-core/report/v2/renderer/util.js
@@ -196,17 +196,13 @@ class Util {
   }
 
   /**
-   * Split a URL into a file and hostname for easy display.
+   * Split a URL into a file, hostname and origin for easy display.
    * @param {string} url
-   * @return {{file: string, hostname: string=}}
+   * @return {{file: string, hostname: string, origin: string}}
    */
   static parseURL(url) {
     const parsedUrl = new URL(url);
-    if (parsedUrl.pathname === '/') {
-      return {file: parsedUrl.origin};
-    } else {
-      return {file: Util.getURLDisplayName(parsedUrl), hostname: parsedUrl.hostname};
-    }
+    return {file: Util.getURLDisplayName(parsedUrl), hostname: parsedUrl.hostname, origin: parsedUrl.origin};
   }
 
   /**

diff --git a/lighthouse-core/test/report/v2/renderer/crc-details-renderer-test.js b/lighthouse-core/test/report/v2/renderer/crc-details-renderer-test.js
@@ -95,7 +95,7 @@ describe('DetailsRenderer', () => {
 
     // Main request
     assert.equal(chains.length, 4, 'generates correct number of chain nodes');
-    assert.equal(chains[0].querySelector('.crc-node__tree-hostname').textContent, '');
+    assert.equal(chains[0].querySelector('.crc-node__tree-hostname').textContent, '(example.com)');
 
     // Children
     assert.ok(chains[1].querySelector('.crc-node__tree-marker .vert-right'));