feedback

build/bundle-builder.js → build/build-bundle.js

@@ -140,12 +140,19 @@ async function build(entryPath, distPath) {
   minifyScript(distPath);
 }
 
-// @ts-ignore Test if called from the CLI or as a module.
-if (require.main === module) {
+/**
+ * @param {Array<string>} argv
+ */
+async function cli(argv) {
   // Take paths relative to cwd and build.
-  const [entryPath, distPath] = process.argv.slice(2)
+  const [entryPath, distPath] = argv.slice(2)
     .map(filePath => path.resolve(process.cwd(), filePath));
   build(entryPath, distPath);
+}
+
+// @ts-ignore Test if called from the CLI or as a module.
+if (require.main === module) {
+  cli(process.argv);
 } else {
   module.exports = {
     /** The commit hash for the current HEAD. */

build/build-extension.js

@@ -10,12 +10,14 @@ const fs = require('fs');
 const archiver = require('archiver');
 const cpy = require('cpy');
 const makeDir = require('make-dir');
-const bundleBuilder = require('./bundle-builder.js');
+const bundleBuilder = require('./build-bundle.js');
 
-const sourceDir = __dirname + '/../clients/extension';
 const sourceName = 'extension-entry.js';
-const distDir = __dirname + '/../dist/extension';
 const distName = 'lighthouse-ext-bundle.js';
+
+const sourceDir = __dirname + '/../clients/extension';
+const distDir = __dirname + '/../dist/extension';
+
 const manifestVersion = require(`${sourceDir}/manifest.json`).version;
 
 /**

package.json

@@ -19,8 +19,8 @@
     "build-all:task": "yarn build-extension & yarn build-devtools & yarn build-lr & yarn build-viewer & wait",
     "build-all:task:windows": "yarn build-extension && yarn build-devtools && yarn build-lr && yarn build-viewer",
     "build-extension": "node ./build/build-extension.js",
-    "build-devtools": "node ./build/bundle-builder.js clients/devtools-entry.js dist/lighthouse-dt-bundle.js",
-    "build-lr": "node ./build/bundle-builder.js clients/lightrider-entry.js dist/lighthouse-lr-bundle.js",
+    "build-devtools": "node ./build/build-bundle.js clients/devtools-entry.js dist/lighthouse-dt-bundle.js",
+    "build-lr": "node ./build/build-bundle.js clients/lightrider-entry.js dist/lighthouse-lr-bundle.js",
     "build-viewer": "cd ./lighthouse-viewer && yarn build",
     "clean": "rimraf dist proto/scripts/*.json proto/scripts/*_pb2.* proto/scripts/*_pb.* proto/scripts/__pycache__ proto/scripts/*.pyc *.report.html *.report.dom.html *.report.json *.devtoolslog.json *.trace.json || true",
     "lint": "[ \"$CI\" = true ] && eslint --quiet -f codeframe . || eslint .",