feedback.

GoogleChrome · Mar 13, 2018 · c2e25b5 · c2e25b5
1 parent 5e1337d
commit c2e25b5
Showing 1 changed file with 3 additions and 12 deletions.
diff --git a/lighthouse-core/report/v2/renderer/report-renderer.js b/lighthouse-core/report/v2/renderer/report-renderer.js
@@ -33,6 +33,9 @@ class ReportRenderer {
  // If any mutations happen to the report within the renderers, we want the original object untouched
  const clone = /** @type {!ReportRenderer.ReportJSON} */ (JSON.parse(JSON.stringify(report)));
 
+ if (!Array.isArray(report.reportCategories)) throw new Error('No reportCategories provided.');
+ ReportRenderer.smooshAuditResultsIntoCategories(report.audits, report.reportCategories);
+
  container.textContent = ''; // Remove previous report.
  const element = container.appendChild(this._renderReport(clone));
  return /** @type {!Element} **/ (element);
@@ -158,8 +161,6 @@ class ReportRenderer {
 
  const categories = reportSection.appendChild(this._dom.createElement('div', 'lh-categories'));
 
- ReportRenderer.smooshAuditResultsIntoCategories(report.audits, report.reportCategories);
-
  for (const category of report.reportCategories) {
  if (scoreHeader) {
  scoreHeader.appendChild(categoryRenderer.renderScoreGauge(category));
@@ -198,16 +199,6 @@ if (typeof module !== 'undefined' && module.exports) {
  self.ReportRenderer = ReportRenderer;
 }
 
-/**
- * @typedef {{
- * id: string,
- * weight: number,
- * group: (string|undefined),
- * result: (ReportRenderer.AuditResultJSON|undefined)
- * }}
- */
-ReportRenderer.AuditJSON; // eslint-disable-line no-unused-expressions
-
 /**
  * @typedef {{
  * rawValue: (number|boolean|undefined),