Skip to content

Commit

Permalink
ward feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Nov 5, 2018
1 parent 7707823 commit d2b6b34
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
5 changes: 5 additions & 0 deletions lighthouse-core/report/html/report-styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@
display: none !important;
}

/* Edge doesn't recognize these, and the polyfill doesn't set block. https://github.com/javan/details-element-polyfill/issues/13 */
details, summary {

This comment has been minimized.

Copy link
@wardpeet

wardpeet Nov 5, 2018

Collaborator

Just adding details is enough. Summary is taken care of by the pollyfill but I'm fine with this

This comment has been minimized.

Copy link
@paulirish

paulirish Nov 5, 2018

Author Member

Yeah i was thinking this too, but then remembered we use <summary> outside of details:

image

This comment has been minimized.

Copy link
@wardpeet

wardpeet Nov 5, 2018

Collaborator

I actually removed that from happening as the pollyfill broke on my branch which is on master now

display: block;
}

.lh-root details > summary {
cursor: pointer;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ Details Element Polyfill 2.0.4
Copyright © 2018 Javan Makhmali
*/

(function() {


}).call(this);
(function() {
var addAttributesForSummary, eventIsSignificant, findClosestElementWithTagName, findElementsWithTagName, onTogglingTrigger, polyfillFocusAndARIA, polyfillProperties, polyfillStyles, polyfillToggle, polyfillToggleEvent, support, triggerToggle, triggerToggleIfToggled;

Expand Down Expand Up @@ -290,8 +286,4 @@ Copyright © 2018 Javan Makhmali
polyfillToggleEvent();
}

}).call(this);
(function() {


}).call(this);

0 comments on commit d2b6b34

Please sign in to comment.