rebase

GoogleChrome · May 3, 2018 · e2ac49c · e2ac49c
1 parent 1ec13a4
commit e2ac49c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lighthouse-core/config/config.js b/lighthouse-core/config/config.js
@@ -63,10 +63,15 @@ function validateCategories(categories, audits, groups) {
       }
 
       const auditImpl = audit.implementation;
-      if (categoryId === 'accessibility' && !auditRef.group && !auditImpl.meta.manual) {
+      const isManual = auditImpl.meta.scoreDisplayMode === 'manual';
+      if (categoryId === 'accessibility' && !auditRef.group && !isManual) {
         throw new Error(`${auditRef.id} accessibility audit does not have a group`);
       }
 
+      if (auditRef.weight > 0 && isManual) {
+        throw new Error(`${auditRef.id} is manual but has a positive weight`);
+      }
+
       if (auditRef.group && !groups[auditRef.group]) {
         throw new Error(`${auditRef.id} references unknown group ${auditRef.group}`);
       }

diff --git a/lighthouse-core/test/config/config-test.js b/lighthouse-core/test/config/config-test.js
@@ -271,6 +271,19 @@ describe('Config', () => {
     }), /unknown group missing-group/);
   });
 
+  it('throws when a manual audit has weight', () => {
+    return assert.throws(_ => new Config({
+      audits: ['manual/pwa-cross-browser'],
+      categories: {
+        accessibility: {
+          audits: [
+            {id: 'pwa-cross-browser', weight: 10},
+          ],
+        },
+      },
+    }), /cross-browser .*has a positive weight/);
+  });
+
   it('filters the config', () => {
     const config = new Config({
       settings: {